Changelog
Copy
View as Markdown

1 min read 1 like

Fixed: some Machine reservation purchases failed or never finished processing

Jacob Fenton

We recently fixed a few bugs related to Machines reservations and were caused by a mishandling of:

  • Organisations without a full billing address on file
    • For these, the payment failed but the reservation appeared to remain “Processing” forever
    • We were mistakenly asking our billing engine to calculate tax for us, and an incomplete billing address caused Stripe (we use Stripe to process payments) to throw it’s hands up and delete the invoice.
  • A quirk of Stripe Billing
    • Sometimes, if an invoice is very small (I’m not certain of the threshold but let’s say <$1), Stripe will not attempt to charge the payment method on file, and will instead maintain the amount due as a “balance” against the account.
    • This balance is applied to subsequent invoices, e.g. a Machines reservation invoice. Applying the balance changes the amount due, but we had code that was expecting the amount due to equal the cost of the reservation exactly.
    • In this case, payments were successful but the reservation was never moved out of “Processing”. The credit was in fact created and capable of paying for usage, but our billing dashboard did not reflect that.

We fixed both these issues and manually resolved all affected reservations. If you have any questions, please reach out to billing@fly.io